OSDN Git Service

Merge branch 'next' into for-linus
authorJames Morris <jmorris@namei.org>
Sun, 28 Feb 2010 22:36:31 +0000 (09:36 +1100)
committerJames Morris <jmorris@namei.org>
Sun, 28 Feb 2010 22:36:31 +0000 (09:36 +1100)
1  2 
kernel/printk.c
security/security.c
security/tomoyo/tomoyo.c

diff --combined kernel/printk.c
@@@ -35,6 -35,7 +35,7 @@@
  #include <linux/kexec.h>
  #include <linux/ratelimit.h>
  #include <linux/kmsg_dump.h>
+ #include <linux/syslog.h>
  
  #include <asm/uaccess.h>
  
@@@ -258,38 -259,23 +259,23 @@@ static inline void boot_delay_msec(void
  }
  #endif
  
- /*
-  * Commands to do_syslog:
-  *
-  *    0 -- Close the log.  Currently a NOP.
-  *    1 -- Open the log. Currently a NOP.
-  *    2 -- Read from the log.
-  *    3 -- Read all messages remaining in the ring buffer.
-  *    4 -- Read and clear all messages remaining in the ring buffer
-  *    5 -- Clear ring buffer.
-  *    6 -- Disable printk's to console
-  *    7 -- Enable printk's to console
-  *    8 -- Set level of messages printed to console
-  *    9 -- Return number of unread characters in the log buffer
-  *     10 -- Return size of the log buffer
-  */
- int do_syslog(int type, char __user *buf, int len)
+ int do_syslog(int type, char __user *buf, int len, bool from_file)
  {
        unsigned i, j, limit, count;
        int do_clear = 0;
        char c;
        int error = 0;
  
-       error = security_syslog(type);
+       error = security_syslog(type, from_file);
        if (error)
                return error;
  
        switch (type) {
-       case 0:         /* Close log */
+       case SYSLOG_ACTION_CLOSE:       /* Close log */
                break;
-       case 1:         /* Open log */
+       case SYSLOG_ACTION_OPEN:        /* Open log */
                break;
-       case 2:         /* Read from log */
+       case SYSLOG_ACTION_READ:        /* Read from log */
                error = -EINVAL;
                if (!buf || len < 0)
                        goto out;
                if (!error)
                        error = i;
                break;
-       case 4:         /* Read/clear last kernel messages */
+       /* Read/clear last kernel messages */
+       case SYSLOG_ACTION_READ_CLEAR:
                do_clear = 1;
                /* FALL THRU */
-       case 3:         /* Read last kernel messages */
+       /* Read last kernel messages */
+       case SYSLOG_ACTION_READ_ALL:
                error = -EINVAL;
                if (!buf || len < 0)
                        goto out;
                        }
                }
                break;
-       case 5:         /* Clear ring buffer */
+       /* Clear ring buffer */
+       case SYSLOG_ACTION_CLEAR:
                logged_chars = 0;
                break;
-       case 6:         /* Disable logging to console */
+       /* Disable logging to console */
+       case SYSLOG_ACTION_CONSOLE_OFF:
                if (saved_console_loglevel == -1)
                        saved_console_loglevel = console_loglevel;
                console_loglevel = minimum_console_loglevel;
                break;
-       case 7:         /* Enable logging to console */
+       /* Enable logging to console */
+       case SYSLOG_ACTION_CONSOLE_ON:
                if (saved_console_loglevel != -1) {
                        console_loglevel = saved_console_loglevel;
                        saved_console_loglevel = -1;
                }
                break;
-       case 8:         /* Set level of messages printed to console */
+       /* Set level of messages printed to console */
+       case SYSLOG_ACTION_CONSOLE_LEVEL:
                error = -EINVAL;
                if (len < 1 || len > 8)
                        goto out;
                saved_console_loglevel = -1;
                error = 0;
                break;
-       case 9:         /* Number of chars in the log buffer */
+       /* Number of chars in the log buffer */
+       case SYSLOG_ACTION_SIZE_UNREAD:
                error = log_end - log_start;
                break;
-       case 10:        /* Size of the log buffer */
+       /* Size of the log buffer */
+       case SYSLOG_ACTION_SIZE_BUFFER:
                error = log_buf_len;
                break;
        default:
@@@ -417,7 -411,7 +411,7 @@@ out
  
  SYSCALL_DEFINE3(syslog, int, type, char __user *, buf, int, len)
  {
-       return do_syslog(type, buf, len);
+       return do_syslog(type, buf, len, SYSLOG_FROM_CALL);
  }
  
  /*
@@@ -1467,7 -1461,6 +1461,7 @@@ EXPORT_SYMBOL_GPL(kmsg_dump_unregister)
  static const char const *kmsg_reasons[] = {
        [KMSG_DUMP_OOPS]        = "oops",
        [KMSG_DUMP_PANIC]       = "panic",
 +      [KMSG_DUMP_KEXEC]       = "kexec",
  };
  
  static const char *kmsg_to_str(enum kmsg_dump_reason reason)
diff --combined security/security.c
@@@ -23,10 -23,12 +23,12 @@@ static __initdata char chosen_lsm[SECUR
        CONFIG_DEFAULT_SECURITY;
  
  /* things that live in capability.c */
- extern struct security_operations default_security_ops;
  extern void security_fixup_ops(struct security_operations *ops);
  
- struct security_operations *security_ops;     /* Initialized to NULL */
+ static struct security_operations *security_ops;
+ static struct security_operations default_security_ops = {
+       .name   = "default",
+ };
  
  static inline int verify(struct security_operations *ops)
  {
@@@ -63,6 -65,11 +65,11 @@@ int __init security_init(void
        return 0;
  }
  
+ void reset_security_ops(void)
+ {
+       security_ops = &default_security_ops;
+ }
  /* Save user chosen LSM */
  static int __init choose_lsm(char *str)
  {
@@@ -203,9 -210,9 +210,9 @@@ int security_quota_on(struct dentry *de
        return security_ops->quota_on(dentry);
  }
  
- int security_syslog(int type)
+ int security_syslog(int type, bool from_file)
  {
-       return security_ops->syslog(type);
+       return security_ops->syslog(type, from_file);
  }
  
  int security_settime(struct timespec *ts, struct timezone *tz)
@@@ -389,42 -396,42 +396,42 @@@ int security_inode_init_security(struc
  EXPORT_SYMBOL(security_inode_init_security);
  
  #ifdef CONFIG_SECURITY_PATH
- int security_path_mknod(struct path *path, struct dentry *dentry, int mode,
+ int security_path_mknod(struct path *dir, struct dentry *dentry, int mode,
                        unsigned int dev)
  {
-       if (unlikely(IS_PRIVATE(path->dentry->d_inode)))
+       if (unlikely(IS_PRIVATE(dir->dentry->d_inode)))
                return 0;
-       return security_ops->path_mknod(path, dentry, mode, dev);
+       return security_ops->path_mknod(dir, dentry, mode, dev);
  }
  EXPORT_SYMBOL(security_path_mknod);
  
- int security_path_mkdir(struct path *path, struct dentry *dentry, int mode)
+ int security_path_mkdir(struct path *dir, struct dentry *dentry, int mode)
  {
-       if (unlikely(IS_PRIVATE(path->dentry->d_inode)))
+       if (unlikely(IS_PRIVATE(dir->dentry->d_inode)))
                return 0;
-       return security_ops->path_mkdir(path, dentry, mode);
+       return security_ops->path_mkdir(dir, dentry, mode);
  }
  
- int security_path_rmdir(struct path *path, struct dentry *dentry)
+ int security_path_rmdir(struct path *dir, struct dentry *dentry)
  {
-       if (unlikely(IS_PRIVATE(path->dentry->d_inode)))
+       if (unlikely(IS_PRIVATE(dir->dentry->d_inode)))
                return 0;
-       return security_ops->path_rmdir(path, dentry);
+       return security_ops->path_rmdir(dir, dentry);
  }
  
- int security_path_unlink(struct path *path, struct dentry *dentry)
+ int security_path_unlink(struct path *dir, struct dentry *dentry)
  {
-       if (unlikely(IS_PRIVATE(path->dentry->d_inode)))
+       if (unlikely(IS_PRIVATE(dir->dentry->d_inode)))
                return 0;
-       return security_ops->path_unlink(path, dentry);
+       return security_ops->path_unlink(dir, dentry);
  }
  
- int security_path_symlink(struct path *path, struct dentry *dentry,
+ int security_path_symlink(struct path *dir, struct dentry *dentry,
                          const char *old_name)
  {
-       if (unlikely(IS_PRIVATE(path->dentry->d_inode)))
+       if (unlikely(IS_PRIVATE(dir->dentry->d_inode)))
                return 0;
-       return security_ops->path_symlink(path, dentry, old_name);
+       return security_ops->path_symlink(dir, dentry, old_name);
  }
  
  int security_path_link(struct dentry *old_dentry, struct path *new_dir,
@@@ -630,14 -637,14 +637,14 @@@ int security_inode_killpriv(struct dent
  int security_inode_getsecurity(const struct inode *inode, const char *name, void **buffer, bool alloc)
  {
        if (unlikely(IS_PRIVATE(inode)))
-               return 0;
+               return -EOPNOTSUPP;
        return security_ops->inode_getsecurity(inode, name, buffer, alloc);
  }
  
  int security_inode_setsecurity(struct inode *inode, const char *name, const void *value, size_t size, int flags)
  {
        if (unlikely(IS_PRIVATE(inode)))
-               return 0;
+               return -EOPNOTSUPP;
        return security_ops->inode_setsecurity(inode, name, value, size, flags);
  }
  
@@@ -666,6 -673,8 +673,6 @@@ int security_file_alloc(struct file *fi
  void security_file_free(struct file *file)
  {
        security_ops->file_free_security(file);
 -      if (file->f_dentry)
 -              ima_file_free(file);
  }
  
  int security_file_ioctl(struct file *file, unsigned int cmd, unsigned long arg)
diff --combined security/tomoyo/tomoyo.c
@@@ -11,8 -11,6 +11,6 @@@
  
  #include <linux/security.h>
  #include "common.h"
- #include "tomoyo.h"
- #include "realpath.h"
  
  static int tomoyo_cred_alloc_blank(struct cred *new, gfp_t gfp)
  {
  static int tomoyo_cred_prepare(struct cred *new, const struct cred *old,
                               gfp_t gfp)
  {
-       /*
-        * Since "struct tomoyo_domain_info *" is a sharable pointer,
-        * we don't need to duplicate.
-        */
-       new->security = old->security;
+       struct tomoyo_domain_info *domain = old->security;
+       new->security = domain;
+       if (domain)
+               atomic_inc(&domain->users);
        return 0;
  }
  
  static void tomoyo_cred_transfer(struct cred *new, const struct cred *old)
  {
-       /*
-        * Since "struct tomoyo_domain_info *" is a sharable pointer,
-        * we don't need to duplicate.
-        */
-       new->security = old->security;
+       tomoyo_cred_prepare(new, old, 0);
+ }
+ static void tomoyo_cred_free(struct cred *cred)
+ {
+       struct tomoyo_domain_info *domain = cred->security;
+       if (domain)
+               atomic_dec(&domain->users);
  }
  
  static int tomoyo_bprm_set_creds(struct linux_binprm *bprm)
        if (!tomoyo_policy_loaded)
                tomoyo_load_policy(bprm->filename);
        /*
+        * Release reference to "struct tomoyo_domain_info" stored inside
+        * "bprm->cred->security". New reference to "struct tomoyo_domain_info"
+        * stored inside "bprm->cred->security" will be acquired later inside
+        * tomoyo_find_next_domain().
+        */
+       atomic_dec(&((struct tomoyo_domain_info *)
+                    bprm->cred->security)->users);
+       /*
         * Tell tomoyo_bprm_check_security() is called for the first time of an
         * execve operation.
         */
@@@ -76,78 -84,72 +84,71 @@@ static int tomoyo_bprm_check_security(s
         * Execute permission is checked against pathname passed to do_execve()
         * using current domain.
         */
-       if (!domain)
-               return tomoyo_find_next_domain(bprm);
+       if (!domain) {
+               const int idx = tomoyo_read_lock();
+               const int err = tomoyo_find_next_domain(bprm);
+               tomoyo_read_unlock(idx);
+               return err;
+       }
        /*
         * Read permission is checked against interpreters using next domain.
 -       * '1' is the result of open_to_namei_flags(O_RDONLY).
         */
 -      return tomoyo_check_open_permission(domain, &bprm->file->f_path, 1);
 +      return tomoyo_check_open_permission(domain, &bprm->file->f_path, O_RDONLY);
  }
  
  static int tomoyo_path_truncate(struct path *path, loff_t length,
                                unsigned int time_attrs)
  {
-       return tomoyo_check_1path_perm(tomoyo_domain(),
-                                      TOMOYO_TYPE_TRUNCATE_ACL,
-                                      path);
+       return tomoyo_path_perm(TOMOYO_TYPE_TRUNCATE, path);
  }
  
  static int tomoyo_path_unlink(struct path *parent, struct dentry *dentry)
  {
        struct path path = { parent->mnt, dentry };
-       return tomoyo_check_1path_perm(tomoyo_domain(),
-                                      TOMOYO_TYPE_UNLINK_ACL,
-                                      &path);
+       return tomoyo_path_perm(TOMOYO_TYPE_UNLINK, &path);
  }
  
  static int tomoyo_path_mkdir(struct path *parent, struct dentry *dentry,
                             int mode)
  {
        struct path path = { parent->mnt, dentry };
-       return tomoyo_check_1path_perm(tomoyo_domain(),
-                                      TOMOYO_TYPE_MKDIR_ACL,
-                                      &path);
+       return tomoyo_path_perm(TOMOYO_TYPE_MKDIR, &path);
  }
  
  static int tomoyo_path_rmdir(struct path *parent, struct dentry *dentry)
  {
        struct path path = { parent->mnt, dentry };
-       return tomoyo_check_1path_perm(tomoyo_domain(),
-                                      TOMOYO_TYPE_RMDIR_ACL,
-                                      &path);
+       return tomoyo_path_perm(TOMOYO_TYPE_RMDIR, &path);
  }
  
  static int tomoyo_path_symlink(struct path *parent, struct dentry *dentry,
                               const char *old_name)
  {
        struct path path = { parent->mnt, dentry };
-       return tomoyo_check_1path_perm(tomoyo_domain(),
-                                      TOMOYO_TYPE_SYMLINK_ACL,
-                                      &path);
+       return tomoyo_path_perm(TOMOYO_TYPE_SYMLINK, &path);
  }
  
  static int tomoyo_path_mknod(struct path *parent, struct dentry *dentry,
                             int mode, unsigned int dev)
  {
        struct path path = { parent->mnt, dentry };
-       int type = TOMOYO_TYPE_CREATE_ACL;
+       int type = TOMOYO_TYPE_CREATE;
  
        switch (mode & S_IFMT) {
        case S_IFCHR:
-               type = TOMOYO_TYPE_MKCHAR_ACL;
+               type = TOMOYO_TYPE_MKCHAR;
                break;
        case S_IFBLK:
-               type = TOMOYO_TYPE_MKBLOCK_ACL;
+               type = TOMOYO_TYPE_MKBLOCK;
                break;
        case S_IFIFO:
-               type = TOMOYO_TYPE_MKFIFO_ACL;
+               type = TOMOYO_TYPE_MKFIFO;
                break;
        case S_IFSOCK:
-               type = TOMOYO_TYPE_MKSOCK_ACL;
+               type = TOMOYO_TYPE_MKSOCK;
                break;
        }
-       return tomoyo_check_1path_perm(tomoyo_domain(),
-                                      type, &path);
+       return tomoyo_path_perm(type, &path);
  }
  
  static int tomoyo_path_link(struct dentry *old_dentry, struct path *new_dir,
  {
        struct path path1 = { new_dir->mnt, old_dentry };
        struct path path2 = { new_dir->mnt, new_dentry };
-       return tomoyo_check_2path_perm(tomoyo_domain(),
-                                      TOMOYO_TYPE_LINK_ACL,
-                                      &path1, &path2);
+       return tomoyo_path2_perm(TOMOYO_TYPE_LINK, &path1, &path2);
  }
  
  static int tomoyo_path_rename(struct path *old_parent,
  {
        struct path path1 = { old_parent->mnt, old_dentry };
        struct path path2 = { new_parent->mnt, new_dentry };
-       return tomoyo_check_2path_perm(tomoyo_domain(),
-                                      TOMOYO_TYPE_RENAME_ACL,
-                                      &path1, &path2);
+       return tomoyo_path2_perm(TOMOYO_TYPE_RENAME, &path1, &path2);
  }
  
  static int tomoyo_file_fcntl(struct file *file, unsigned int cmd,
                             unsigned long arg)
  {
        if (cmd == F_SETFL && ((arg ^ file->f_flags) & O_APPEND))
-               return tomoyo_check_rewrite_permission(tomoyo_domain(), file);
+               return tomoyo_check_rewrite_permission(file);
        return 0;
  }
  
  static int tomoyo_dentry_open(struct file *f, const struct cred *cred)
  {
        int flags = f->f_flags;
 -
 -      if ((flags + 1) & O_ACCMODE)
 -              flags++;
 -      flags |= f->f_flags & (O_APPEND | O_TRUNC);
        /* Don't check read permission here if called from do_execve(). */
        if (current->in_execve)
                return 0;
        return tomoyo_check_open_permission(tomoyo_domain(), &f->f_path, flags);
  }
  
+ static int tomoyo_file_ioctl(struct file *file, unsigned int cmd,
+                            unsigned long arg)
+ {
+       return tomoyo_path_perm(TOMOYO_TYPE_IOCTL, &file->f_path);
+ }
+ static int tomoyo_path_chmod(struct dentry *dentry, struct vfsmount *mnt,
+                            mode_t mode)
+ {
+       struct path path = { mnt, dentry };
+       return tomoyo_path_perm(TOMOYO_TYPE_CHMOD, &path);
+ }
+ static int tomoyo_path_chown(struct path *path, uid_t uid, gid_t gid)
+ {
+       int error = 0;
+       if (uid != (uid_t) -1)
+               error = tomoyo_path_perm(TOMOYO_TYPE_CHOWN, path);
+       if (!error && gid != (gid_t) -1)
+               error = tomoyo_path_perm(TOMOYO_TYPE_CHGRP, path);
+       return error;
+ }
+ static int tomoyo_path_chroot(struct path *path)
+ {
+       return tomoyo_path_perm(TOMOYO_TYPE_CHROOT, path);
+ }
+ static int tomoyo_sb_mount(char *dev_name, struct path *path,
+                          char *type, unsigned long flags, void *data)
+ {
+       return tomoyo_path_perm(TOMOYO_TYPE_MOUNT, path);
+ }
+ static int tomoyo_sb_umount(struct vfsmount *mnt, int flags)
+ {
+       struct path path = { mnt, mnt->mnt_root };
+       return tomoyo_path_perm(TOMOYO_TYPE_UMOUNT, &path);
+ }
+ static int tomoyo_sb_pivotroot(struct path *old_path, struct path *new_path)
+ {
+       return tomoyo_path2_perm(TOMOYO_TYPE_PIVOT_ROOT, new_path, old_path);
+ }
  /*
   * tomoyo_security_ops is a "struct security_operations" which is used for
   * registering TOMOYO.
@@@ -198,6 -245,7 +240,7 @@@ static struct security_operations tomoy
        .cred_alloc_blank    = tomoyo_cred_alloc_blank,
        .cred_prepare        = tomoyo_cred_prepare,
        .cred_transfer       = tomoyo_cred_transfer,
+       .cred_free           = tomoyo_cred_free,
        .bprm_set_creds      = tomoyo_bprm_set_creds,
        .bprm_check_security = tomoyo_bprm_check_security,
        .file_fcntl          = tomoyo_file_fcntl,
        .path_mknod          = tomoyo_path_mknod,
        .path_link           = tomoyo_path_link,
        .path_rename         = tomoyo_path_rename,
+       .file_ioctl          = tomoyo_file_ioctl,
+       .path_chmod          = tomoyo_path_chmod,
+       .path_chown          = tomoyo_path_chown,
+       .path_chroot         = tomoyo_path_chroot,
+       .sb_mount            = tomoyo_sb_mount,
+       .sb_umount           = tomoyo_sb_umount,
+       .sb_pivotroot        = tomoyo_sb_pivotroot,
  };
  
+ /* Lock for GC. */
+ struct srcu_struct tomoyo_ss;
  static int __init tomoyo_init(void)
  {
        struct cred *cred = (struct cred *) current_cred();
        if (!security_module_enable(&tomoyo_security_ops))
                return 0;
        /* register ourselves with the security framework */
-       if (register_security(&tomoyo_security_ops))
+       if (register_security(&tomoyo_security_ops) ||
+           init_srcu_struct(&tomoyo_ss))
                panic("Failure registering TOMOYO Linux");
        printk(KERN_INFO "TOMOYO Linux initialized\n");
        cred->security = &tomoyo_kernel_domain;