OSDN Git Service

e1000e: cosmetic change to boolean comparisons
authorBruce Allan <bruce.w.allan@intel.com>
Fri, 17 Feb 2012 03:17:55 +0000 (03:17 +0000)
committerJeff Kirsher <jeffrey.t.kirsher@intel.com>
Fri, 24 Feb 2012 09:58:27 +0000 (01:58 -0800)
Recent discussions on LKML, kernel-janitors, linux-wireless and netdev
have suggested boolean comparisons should use logical operators instead of
equality comparisons with true/false.

Signed-off-by: Bruce Allan <bruce.w.allan@intel.com>
Tested-by: Aaron Brown <aaron.f.brown@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
drivers/net/ethernet/intel/e1000e/80003es2lan.c

index bc960fe..3c2daa7 100644 (file)
@@ -458,7 +458,7 @@ static s32 e1000_read_phy_reg_gg82563_80003es2lan(struct e1000_hw *hw,
                return ret_val;
        }
 
-       if (hw->dev_spec.e80003es2lan.mdic_wa_enable == true) {
+       if (hw->dev_spec.e80003es2lan.mdic_wa_enable) {
                /*
                 * The "ready" bit in the MDIC register may be incorrectly set
                 * before the device has completed the "Page Select" MDI
@@ -529,7 +529,7 @@ static s32 e1000_write_phy_reg_gg82563_80003es2lan(struct e1000_hw *hw,
                return ret_val;
        }
 
-       if (hw->dev_spec.e80003es2lan.mdic_wa_enable == true) {
+       if (hw->dev_spec.e80003es2lan.mdic_wa_enable) {
                /*
                 * The "ready" bit in the MDIC register may be incorrectly set
                 * before the device has completed the "Page Select" MDI