OSDN Git Service

ASoC: codecs: rt*-sdw: don't assign slave_ops
authorPierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Fri, 15 May 2020 21:15:29 +0000 (16:15 -0500)
committerMark Brown <broonie@kernel.org>
Mon, 18 May 2020 11:38:28 +0000 (12:38 +0100)
The SoundWire bus core already assigns the slave ops, no need to set
them a second time manually in each driver.

Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Reviewed-by: Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>
Reviewed-by: Rander Wang <rander.wang@intel.com>
Cc: Oder Chiou <oder_chiou@realtek.com>
Cc: Shuming Fan <shumingf@realtek.com>
Cc: Jack Yu <jack.yu@realtek.com>
Link: https://lore.kernel.org/r/20200515211531.11416-2-pierre-louis.bossart@linux.intel.com
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/codecs/rt1308-sdw.c
sound/soc/codecs/rt5682-sdw.c
sound/soc/codecs/rt700-sdw.c
sound/soc/codecs/rt711-sdw.c
sound/soc/codecs/rt715-sdw.c

index 1502a22..4b88fa8 100644 (file)
@@ -684,9 +684,6 @@ static int rt1308_sdw_probe(struct sdw_slave *slave,
 {
        struct regmap *regmap;
 
-       /* Assign ops */
-       slave->ops = &rt1308_slave_ops;
-
        /* Regmap Initialization */
        regmap = devm_regmap_init_sdw(slave, &rt1308_sdw_regmap);
        if (!regmap)
index a2d1d3a..99dd48d 100644 (file)
@@ -241,9 +241,6 @@ static int rt5682_sdw_probe(struct sdw_slave *slave,
 {
        struct regmap *regmap;
 
-       /* Assign ops */
-       slave->ops = &rt5682_slave_ops;
-
        /* Regmap Initialization */
        regmap = devm_regmap_init_sdw(slave, &rt5682_sdw_regmap);
        if (IS_ERR(regmap))
index d4e0f95..4d14048 100644 (file)
@@ -450,9 +450,6 @@ static int rt700_sdw_probe(struct sdw_slave *slave,
 {
        struct regmap *sdw_regmap, *regmap;
 
-       /* Assign ops */
-       slave->ops = &rt700_slave_ops;
-
        /* Regmap Initialization */
        sdw_regmap = devm_regmap_init_sdw(slave, &rt700_sdw_regmap);
        if (!sdw_regmap)
index fc3a3fa..45b9289 100644 (file)
@@ -450,9 +450,6 @@ static int rt711_sdw_probe(struct sdw_slave *slave,
 {
        struct regmap *sdw_regmap, *regmap;
 
-       /* Assign ops */
-       slave->ops = &rt711_slave_ops;
-
        /* Regmap Initialization */
        sdw_regmap = devm_regmap_init_sdw(slave, &rt711_sdw_regmap);
        if (!sdw_regmap)
index 64ef56e..d11b23d 100644 (file)
@@ -525,9 +525,6 @@ static int rt715_sdw_probe(struct sdw_slave *slave,
 {
        struct regmap *sdw_regmap, *regmap;
 
-       /* Assign ops */
-       slave->ops = &rt715_slave_ops;
-
        /* Regmap Initialization */
        sdw_regmap = devm_regmap_init_sdw(slave, &rt715_sdw_regmap);
        if (!sdw_regmap)