OSDN Git Service

ila: Fix rhashtable walker list corruption
authorHerbert Xu <herbert@gondor.apana.org.au>
Tue, 26 Mar 2019 05:50:14 +0000 (13:50 +0800)
committerDavid S. Miller <davem@davemloft.net>
Thu, 28 Mar 2019 05:46:16 +0000 (22:46 -0700)
ila_xlat_nl_cmd_flush uses rhashtable walkers allocated from the
stack but it never frees them.  This corrupts the walker list of
the hash table.

This patch fixes it.

Reported-by: syzbot+dae72a112334aa65a159@syzkaller.appspotmail.com
Fixes: b6e71bdebb12 ("ila: Flush netlink command to clear xlat...")
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/ipv6/ila/ila_xlat.c

index 79d2e43..5fc1f4e 100644 (file)
@@ -417,6 +417,7 @@ int ila_xlat_nl_cmd_flush(struct sk_buff *skb, struct genl_info *info)
 
 done:
        rhashtable_walk_stop(&iter);
+       rhashtable_walk_exit(&iter);
        return ret;
 }