OSDN Git Service

net: ethernet: ti: davinci_cpdma: free memory while channel destroy
authorIvan Khoronzhuk <ivan.khoronzhuk@linaro.org>
Tue, 8 Nov 2016 13:16:05 +0000 (15:16 +0200)
committerDavid S. Miller <davem@davemloft.net>
Sun, 13 Nov 2016 02:06:50 +0000 (21:06 -0500)
While create/destroy channel operation memory is not freed. It was
supposed that memory is freed while driver remove. But a channel
can be created and destroyed many times while changing number of
channels with ethtool.

Based on net-next/master

Signed-off-by: Ivan Khoronzhuk <ivan.khoronzhuk@linaro.org>
Reviewed-by: Grygorii Strashko <grygorii.strashko@ti.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/ti/davinci_cpdma.c

index c3f35f1..8f7b420 100644 (file)
@@ -533,7 +533,7 @@ int cpdma_chan_destroy(struct cpdma_chan *chan)
                cpdma_chan_stop(chan);
        ctlr->channels[chan->chan_num] = NULL;
        ctlr->chan_num--;
-
+       devm_kfree(ctlr->dev, chan);
        cpdma_chan_split_pool(ctlr);
 
        spin_unlock_irqrestore(&ctlr->lock, flags);