OSDN Git Service

media: i2c: ov2640: drop of_match_ptr for ID table
authorKrzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Sun, 12 Mar 2023 13:13:13 +0000 (14:13 +0100)
committerMauro Carvalho Chehab <mchehab@kernel.org>
Fri, 14 Jul 2023 10:36:58 +0000 (12:36 +0200)
The driver will match mostly by DT table (even thought there is regular
ID table) so there is little benefit in of_match_ptr (this also allows
ACPI matching via PRP0001, even though it might not be relevant here).
This also fixes !CONFIG_OF error:

  drivers/media/i2c/ov2640.c:1290:34: error: ‘ov2640_of_match’ defined but not used [-Werror=unused-const-variable=]

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>
drivers/media/i2c/ov2640.c

index ec801a8..bb6c986 100644 (file)
@@ -1296,7 +1296,7 @@ MODULE_DEVICE_TABLE(of, ov2640_of_match);
 static struct i2c_driver ov2640_i2c_driver = {
        .driver = {
                .name = "ov2640",
-               .of_match_table = of_match_ptr(ov2640_of_match),
+               .of_match_table = ov2640_of_match,
        },
        .probe    = ov2640_probe,
        .remove   = ov2640_remove,