OSDN Git Service

tty: serial: meson: use dev_err_probe
authorDmitry Rokosov <ddrokosov@sberdevices.ru>
Wed, 5 Jul 2023 18:18:27 +0000 (21:18 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 25 Jul 2023 18:22:07 +0000 (20:22 +0200)
Use dev_err_probe() helper for error checking and standard logging.
It makes the driver's probe() function a little bit shorter.

Signed-off-by: Dmitry Rokosov <ddrokosov@sberdevices.ru>
Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
Link: https://lore.kernel.org/r/20230705181833.16137-2-ddrokosov@sberdevices.ru
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/tty/serial/meson_uart.c

index 2501db5..bca54f3 100644 (file)
@@ -726,8 +726,8 @@ static int meson_uart_probe(struct platform_device *pdev)
        of_property_read_u32(pdev->dev.of_node, "fifo-size", &fifosize);
 
        if (meson_ports[pdev->id]) {
-               dev_err(&pdev->dev, "port %d already allocated\n", pdev->id);
-               return -EBUSY;
+               return dev_err_probe(&pdev->dev, -EBUSY,
+                                    "port %d already allocated\n", pdev->id);
        }
 
        port = devm_kzalloc(&pdev->dev, sizeof(struct uart_port), GFP_KERNEL);