OSDN Git Service

media: allegro: fail encoding only on actual errors
authorMichael Tretter <m.tretter@pengutronix.de>
Mon, 16 Mar 2020 15:26:22 +0000 (16:26 +0100)
committerMauro Carvalho Chehab <mchehab+huawei@kernel.org>
Fri, 20 Mar 2020 08:08:09 +0000 (09:08 +0100)
Only negative values are actual errors and positive values are used for
warnings. Warnings should not fail the encoding process.

Signed-off-by: Michael Tretter <m.tretter@pengutronix.de>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
drivers/staging/media/allegro-dvt/allegro-core.c

index 9e601a6..56d199c 100644 (file)
@@ -1536,7 +1536,7 @@ static void allegro_channel_finish_frame(struct allegro_channel *channel,
        dst_buf = v4l2_m2m_dst_buf_remove(channel->fh.m2m_ctx);
        dst_buf->sequence = channel->csequence++;
 
-       if (msg->error_code) {
+       if (msg->error_code & AL_ERROR) {
                v4l2_err(&dev->v4l2_dev,
                         "channel %d: failed to encode frame: %s (%x)\n",
                         channel->mcu_channel_id,