OSDN Git Service

fjes: use currently unused variable my_epid and max_epid
authorColin Ian King <colin.king@canonical.com>
Thu, 5 Jul 2018 10:05:32 +0000 (11:05 +0100)
committerDavid S. Miller <davem@davemloft.net>
Thu, 5 Jul 2018 10:34:21 +0000 (19:34 +0900)
Variables my_epid and max_epid are currently assigned and not being
used - however, I suspect they were intended to be used in the for-loops
to reduce the dereferencing of hw.  Replace hw->my_epid and hw->max_epid
with these variables.

Cleans up clang warnings:
warning: variable 'my_epid' set but not used [-Wunused-but-set-variable]
variable 'max_epid' set but not used [-Wunused-but-set-variable]

Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/fjes/fjes_main.c

index 750954b..d3eae12 100644 (file)
@@ -1395,8 +1395,8 @@ static void fjes_watch_unshare_task(struct work_struct *work)
 
        while ((unshare_watch_bitmask || hw->txrx_stop_req_bit) &&
               (wait_time < 3000)) {
-               for (epidx = 0; epidx < hw->max_epid; epidx++) {
-                       if (epidx == hw->my_epid)
+               for (epidx = 0; epidx < max_epid; epidx++) {
+                       if (epidx == my_epid)
                                continue;
 
                        is_shared = fjes_hw_epid_is_shared(hw->hw_info.share,
@@ -1453,8 +1453,8 @@ static void fjes_watch_unshare_task(struct work_struct *work)
        }
 
        if (hw->hw_info.buffer_unshare_reserve_bit) {
-               for (epidx = 0; epidx < hw->max_epid; epidx++) {
-                       if (epidx == hw->my_epid)
+               for (epidx = 0; epidx < max_epid; epidx++) {
+                       if (epidx == my_epid)
                                continue;
 
                        if (test_bit(epidx,