OSDN Git Service

media: atomisp: remove redundant initialization of variable ret
authorColin Ian King <colin.king@canonical.com>
Wed, 9 Jun 2021 12:14:08 +0000 (14:14 +0200)
committerMauro Carvalho Chehab <mchehab+huawei@kernel.org>
Mon, 12 Jul 2021 07:16:34 +0000 (09:16 +0200)
The variable ret is being initialized with a value that is never read,
it is being updated later on. The assignment is redundant and can be
removed.

Addresses-Coverity: ("Unused value")

Signed-off-by: Colin Ian King <colin.king@canonical.com>
Acked-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
drivers/staging/media/atomisp/i2c/ov5693/atomisp-ov5693.c

index 0828ca9..5e3670c 100644 (file)
@@ -932,7 +932,7 @@ err:
 static int ad5823_t_focus_vcm(struct v4l2_subdev *sd, u16 val)
 {
        struct i2c_client *client = v4l2_get_subdevdata(sd);
-       int ret = -EINVAL;
+       int ret;
        u8 vcm_code;
 
        ret = ad5823_i2c_read(client, AD5823_REG_VCM_CODE_MSB, &vcm_code);