selftests: mlxsw: Remove a redundant if statement in port_scale test

Currently, the error return code of the failure condition is lost after
using an if statement, so the test doesn't fail when it should.

Remove the if statement that separates the condition and the error code
check, so the test won't always pass.

Fixes: 5154b1b826d9b ("selftests: mlxsw: Add a scale test for physical ports")
Reported-by: Ido Schimmel <idosch@nvidia.com>
Signed-off-by: Danielle Ratson <danieller@nvidia.com>
Reviewed-by: Petr Machata <petrm@nvidia.com>
Signed-off-by: Petr Machata <petrm@nvidia.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

diff --git a/tools/testing/selftests/drivers/net/mlxsw/port_scale.sh b/tools/testing/selftests/drivers/net/mlxsw/port_scale.sh
index f813ffe..65f43a7 100644 (file)
--- a/tools/testing/selftests/drivers/net/mlxsw/port_scale.sh
+++ b/tools/testing/selftests/drivers/net/mlxsw/port_scale.sh
@@ -55,10 +55,6 @@ port_test()
              | jq '.[][][] | select(.name=="physical_ports") |.["occ"]')
 
        [[ $occ -eq $max_ports ]]
-       if [[ $should_fail -eq 0 ]]; then
-               check_err $? "Mismatch ports number: Expected $max_ports, got $occ."
-       else
-               check_err_fail $should_fail $? "Reached more ports than expected"
-       fi
+       check_err_fail $should_fail $? "Attempt to create $max_ports ports (actual result $occ)"
 
 }