OSDN Git Service

drm/amdgpu: fix size calculation in amdgpu_ttm_copy_mem_to_mem
authorChristian König <christian.koenig@amd.com>
Fri, 3 Apr 2020 13:56:12 +0000 (15:56 +0200)
committerAlex Deucher <alexander.deucher@amd.com>
Tue, 28 Apr 2020 20:20:30 +0000 (16:20 -0400)
When the node is larger than 4GB we overrun the size calculation.

Fix this by correctly limiting the size to the window as well.

Signed-off-by: Christian König <christian.koenig@amd.com>
Reviewed-by: Felix Kuehling <Felix.Kuehling@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c

index 0d7ad64..1296499 100644 (file)
@@ -450,9 +450,9 @@ int amdgpu_ttm_copy_mem_to_mem(struct amdgpu_device *adev,
                /* Copy size cannot exceed GTT_MAX_BYTES. So if src or dst
                 * begins at an offset, then adjust the size accordingly
                 */
-               cur_size = min3(src_node_size, dst_node_size, size);
-               cur_size = min(GTT_MAX_BYTES - src_page_offset, cur_size);
-               cur_size = min(GTT_MAX_BYTES - dst_page_offset, cur_size);
+               cur_size = max(src_page_offset, dst_page_offset);
+               cur_size = min(min3(src_node_size, dst_node_size, size),
+                              (uint64_t)(GTT_MAX_BYTES - cur_size));
 
                /* Map src to window 0 and dst to window 1. */
                r = amdgpu_ttm_map_buffer(src->bo, src->mem, src_mm,