OSDN Git Service

atm: idt77105: Drop needless setup_timer()
authorKees Cook <keescook@chromium.org>
Tue, 10 Oct 2017 19:25:48 +0000 (12:25 -0700)
committerDavid S. Miller <davem@davemloft.net>
Wed, 11 Oct 2017 21:15:21 +0000 (14:15 -0700)
Calling setup_timer() is redundant when DEFINE_TIMER() has been used.

Cc: Chas Williams <3chas3@gmail.com>
Cc: linux-atm-general@lists.sourceforge.net
Cc: netdev@vger.kernel.org
Signed-off-by: Kees Cook <keescook@chromium.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/atm/idt77105.c

index 082aa02..d781b3f 100644 (file)
@@ -306,11 +306,9 @@ static int idt77105_start(struct atm_dev *dev)
        if (start_timer) {
                start_timer = 0;
                 
-               setup_timer(&stats_timer, idt77105_stats_timer_func, 0UL);
                stats_timer.expires = jiffies+IDT77105_STATS_TIMER_PERIOD;
                add_timer(&stats_timer);
                 
-               setup_timer(&restart_timer, idt77105_restart_timer_func, 0UL);
                restart_timer.expires = jiffies+IDT77105_RESTART_TIMER_PERIOD;
                add_timer(&restart_timer);
        }