OSDN Git Service

ath: move spin_lock_bh to spin_lock in tasklet
authorZhiwei Jiang <qq282012236@gmail.com>
Tue, 22 Jan 2019 16:30:33 +0000 (00:30 +0800)
committerKalle Valo <kvalo@codeaurora.org>
Thu, 7 Feb 2019 15:01:24 +0000 (17:01 +0200)
as you are already in a tasklet, it is unnecessary to call
spin_lock_bh, because softirq already disable BH.

Signed-off-by: Zhiwei Jiang <qq282012236@gmail.com>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
drivers/net/wireless/ath/ath9k/htc_drv_txrx.c

index 799010e..4e8e80a 100644 (file)
@@ -574,12 +574,12 @@ void ath9k_tx_failed_tasklet(unsigned long data)
 {
        struct ath9k_htc_priv *priv = (struct ath9k_htc_priv *)data;
 
-       spin_lock_bh(&priv->tx.tx_lock);
+       spin_lock(&priv->tx.tx_lock);
        if (priv->tx.flags & ATH9K_HTC_OP_TX_DRAIN) {
-               spin_unlock_bh(&priv->tx.tx_lock);
+               spin_unlock(&priv->tx.tx_lock);
                return;
        }
-       spin_unlock_bh(&priv->tx.tx_lock);
+       spin_unlock(&priv->tx.tx_lock);
 
        ath9k_htc_tx_drainq(priv, &priv->tx.tx_failed);
 }