OSDN Git Service

ARM: dts: dra7: Move the ti,no-idle quirk on proper gmac node
authorTero Kristo <t-kristo@ti.com>
Wed, 28 Nov 2018 10:45:07 +0000 (12:45 +0200)
committerTony Lindgren <tony@atomide.com>
Thu, 29 Nov 2018 19:08:23 +0000 (11:08 -0800)
Hwmod parses the DT hierarchically from root to search for matching
ti,hwmod property. With the introduction of L4 data, we have two nodes
with the ti,hwmod = "gmac" declaration, and the hwmod core only matches
the first one found, which is the target-module one. This node incorrectly
dropped the ti,no-idle flag, which causes number of problems, like ignoring
errata i877, and also causing an intermittent boot failure on certain dra7
boards.

Fix the issue by moving the ti,no-idle flag to the proper node.

Signed-off-by: Tero Kristo <t-kristo@ti.com>
Reported-by: Grygorii Strashko <grygorii.strashko@ti.com>
Reviewed-by: Grygorii Strashko <grygorii.strashko@ti.com>
Signed-off-by: Tony Lindgren <tony@atomide.com>
arch/arm/boot/dts/dra7-l4.dtsi

index 7e5c0d4..6c01ada 100644 (file)
                        #address-cells = <1>;
                        #size-cells = <1>;
                        ranges = <0x0 0x84000 0x4000>;
+                       /*
+                        * Do not allow gating of cpsw clock as workaround
+                        * for errata i877. Keeping internal clock disabled
+                        * causes the device switching characteristics
+                        * to degrade over time and eventually fail to meet
+                        * the data manual delay time/skew specs.
+                        */
+                       ti,no-idle;
 
                        mac: ethernet@0 {
                                compatible = "ti,dra7-cpsw","ti,cpsw";
                                #size-cells = <1>;
 
                                /*
-                                * Do not allow gating of cpsw clock as workaround
-                                * for errata i877. Keeping internal clock disabled
-                                * causes the device switching characteristics
-                                * to degrade over time and eventually fail to meet
-                                * the data manual delay time/skew specs.
-                                */
-                               ti,no-idle;
-
-                               /*
                                 * rx_thresh_pend
                                 * rx_pend
                                 * tx_pend