OSDN Git Service

drm/i915/guc: Update GuC power domain states
authorMichal Wajdeczko <michal.wajdeczko@intel.com>
Mon, 10 Sep 2018 10:41:49 +0000 (10:41 +0000)
committerChris Wilson <chris@chris-wilson.co.uk>
Mon, 10 Sep 2018 19:31:55 +0000 (20:31 +0100)
We should update GuC power domain states also when GuC submission
is disabled, otherwise GuC might complain or ignore our requests.
This seems to be required for all currently released GuC firmwares.

v2: it is only needed by pre-Gen11 firmwares

Signed-off-by: Michal Wajdeczko <michal.wajdeczko@intel.com>
Cc: John Spotswood <john.a.spotswood@intel.com>
Cc: Anusha Srivatsa <anusha.srivatsa@intel.com>
Cc: Tomasz Lis <tomasz.lis@intel.com>
Cc: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
Reviewed-by: Anusha Srivatsa <anusha.srivatsa@intel.com>
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Link: https://patchwork.freedesktop.org/patch/msgid/20180910104150.101752-1-michal.wajdeczko@intel.com
drivers/gpu/drm/i915/intel_uc.c

index 7c95697..b1b3e81 100644 (file)
@@ -401,6 +401,10 @@ int intel_uc_init_hw(struct drm_i915_private *i915)
                ret = intel_guc_submission_enable(guc);
                if (ret)
                        goto err_communication;
+       } else if (INTEL_GEN(i915) < 11) {
+               ret = intel_guc_sample_forcewake(guc);
+               if (ret)
+                       goto err_communication;
        }
 
        dev_info(i915->drm.dev, "GuC firmware version %u.%u\n",