OSDN Git Service

net: dsa: qca8k: remove redundant check in parse_port_config
authorAnsuel Smith <ansuelsmth@gmail.com>
Mon, 22 Nov 2021 15:23:40 +0000 (16:23 +0100)
committerDavid S. Miller <davem@davemloft.net>
Mon, 22 Nov 2021 15:35:16 +0000 (15:35 +0000)
The very next check for port 0 and 6 already makes sure we don't go out
of bounds with the ports_config delay table.
Remove the redundant check.

Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Ansuel Smith <ansuelsmth@gmail.com>
Reviewed-by: Vladimir Oltean <olteanv@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/dsa/qca8k.c

index a429c97..bfffc1f 100644 (file)
@@ -983,7 +983,7 @@ qca8k_parse_port_config(struct qca8k_priv *priv)
        u32 delay;
 
        /* We have 2 CPU port. Check them */
-       for (port = 0; port < QCA8K_NUM_PORTS && cpu_port_index < QCA8K_NUM_CPU_PORTS; port++) {
+       for (port = 0; port < QCA8K_NUM_PORTS; port++) {
                /* Skip every other port */
                if (port != 0 && port != 6)
                        continue;