OSDN Git Service

net: bridge: vlan: enable mcast snooping for existing master vlans
authorNikolay Aleksandrov <nikolay@nvidia.com>
Mon, 16 Aug 2021 14:57:04 +0000 (17:57 +0300)
committerDavid S. Miller <davem@davemloft.net>
Tue, 17 Aug 2021 09:37:28 +0000 (10:37 +0100)
We always create a vlan with enabled mcast snooping, so when the user
turns on per-vlan mcast contexts they'll get consistent behaviour with
the current situation, but one place wasn't updated when a bridge/master
vlan which already exists (created due to port vlans) is being added as
real bridge vlan (BRIDGE_VLAN_INFO_BRENTRY). We need to enable mcast
snooping for that vlan when that happens.

Fixes: 7b54aaaf53cb ("net: bridge: multicast: add vlan state initialization and control")
Signed-off-by: Nikolay Aleksandrov <nikolay@nvidia.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/bridge/br_vlan.c

index cbc9226..e25e288 100644 (file)
@@ -694,6 +694,7 @@ static int br_vlan_add_existing(struct net_bridge *br,
                vlan->flags |= BRIDGE_VLAN_INFO_BRENTRY;
                vg->num_vlans++;
                *changed = true;
+               br_multicast_toggle_one_vlan(vlan, true);
        }
 
        if (__vlan_add_flags(vlan, flags))