drm/v3d: Convert to platform remove callback returning void

The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is (mostly) ignored
and this typically results in resource leaks. To improve here there is a
quest to make the remove callback return void. In the first step of this
quest all drivers are converted to .remove_new() which already returns
void.

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: Douglas Anderson <dianders@chromium.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20230507162616.1368908-52-u.kleine-koenig@pengutronix.de

diff --git a/drivers/gpu/drm/v3d/v3d_drv.c b/drivers/gpu/drm/v3d/v3d_drv.c
index 478f1f0..71f9fdd 100644 (file)
--- a/drivers/gpu/drm/v3d/v3d_drv.c
+++ b/drivers/gpu/drm/v3d/v3d_drv.c
@@ -295,7 +295,7 @@ dma_free:
        return ret;
 }
 
-static int v3d_platform_drm_remove(struct platform_device *pdev)
+static void v3d_platform_drm_remove(struct platform_device *pdev)
 {
        struct drm_device *drm = platform_get_drvdata(pdev);
        struct v3d_dev *v3d = to_v3d_dev(drm);
@@ -306,13 +306,11 @@ static int v3d_platform_drm_remove(struct platform_device *pdev)
 
        dma_free_wc(v3d->drm.dev, 4096, v3d->mmu_scratch,
                    v3d->mmu_scratch_paddr);
-
-       return 0;
 }
 
 static struct platform_driver v3d_platform_driver = {
        .probe          = v3d_platform_drm_probe,
-       .remove         = v3d_platform_drm_remove,
+       .remove_new     = v3d_platform_drm_remove,
        .driver         = {
                .name   = "v3d",
                .of_match_table = v3d_of_match,