OSDN Git Service

firmware: arm_scmi: Drop empty stub for smc_mark_txdone
authorSudeep Holla <sudeep.holla@arm.com>
Fri, 27 Mar 2020 16:36:52 +0000 (16:36 +0000)
committerSudeep Holla <sudeep.holla@arm.com>
Tue, 14 Apr 2020 08:31:48 +0000 (09:31 +0100)
The scmi protocol core driver check for non NULL mark_txdone before
invoking the same. There is no need to provide a empty stub. SMC/HVC
calls are synchronous and the call return indicates the completion.

Link: https://lore.kernel.org/r/20200327163654.13389-3-sudeep.holla@arm.com
Tested-by: Peng Fan <peng.fan@nxp.com>
Reviewed-by: Peng Fan <peng.fan@nxp.com>
Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
drivers/firmware/arm_scmi/smc.c

index 6dc8a88..dd4b54c 100644 (file)
@@ -114,10 +114,6 @@ static int smc_send_message(struct scmi_chan_info *cinfo,
        return res.a0;
 }
 
-static void smc_mark_txdone(struct scmi_chan_info *cinfo, int ret)
-{
-}
-
 static void smc_fetch_response(struct scmi_chan_info *cinfo,
                               struct scmi_xfer *xfer)
 {
@@ -139,7 +135,6 @@ static struct scmi_transport_ops scmi_smc_ops = {
        .chan_setup = smc_chan_setup,
        .chan_free = smc_chan_free,
        .send_message = smc_send_message,
-       .mark_txdone = smc_mark_txdone,
        .fetch_response = smc_fetch_response,
        .poll_done = smc_poll_done,
 };