OSDN Git Service

virtio_ring: use helper function is_power_of_2()
authorShaoqin Huang <shaoqin.huang@intel.com>
Fri, 21 Oct 2022 06:27:34 +0000 (23:27 -0700)
committerMichael S. Tsirkin <mst@redhat.com>
Wed, 28 Dec 2022 10:28:09 +0000 (05:28 -0500)
Use helper function is_power_of_2() to check if num is power of two.
Minor readability improvement.

Signed-off-by: Shaoqin Huang <shaoqin.huang@intel.com>
Message-Id: <20221021062734.228881-3-shaoqin.huang@intel.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Reviewed-by: Xuan Zhuo <xuanzhuo@linux.alibaba.com>
drivers/virtio/virtio_ring.c

index 2e7689b..723c4e2 100644 (file)
@@ -1052,7 +1052,7 @@ static int vring_alloc_queue_split(struct vring_virtqueue_split *vring_split,
        dma_addr_t dma_addr;
 
        /* We assume num is a power of 2. */
-       if (num & (num - 1)) {
+       if (!is_power_of_2(num)) {
                dev_warn(&vdev->dev, "Bad virtqueue length %u\n", num);
                return -EINVAL;
        }