OSDN Git Service

staging: mt7621-mmc: place a check for sscanf
authorSumit Pundir <pundirsumit11@gmail.com>
Fri, 10 Aug 2018 12:31:40 +0000 (18:01 +0530)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 27 Aug 2018 17:31:59 +0000 (19:31 +0200)
Placed a check for the return value of sscanf. -EINVAL is returned if
the value is anything other than expected. Reported by checkpatch.pl

Signed-off-by: Sumit Pundir <pundirsumit11@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/mt7621-mmc/dbg.c

index 6e518dc..4fe4d2f 100644 (file)
@@ -249,7 +249,9 @@ static ssize_t msdc_debug_proc_write(struct file *file,
        cmd_buf[count] = '\0';
        pr_debug("msdc Write %s\n", cmd_buf);
 
-       sscanf(cmd_buf, "%x %x %x", &cmd, &p1, &p2);
+       ret = sscanf(cmd_buf, "%x %x %x", &cmd, &p1, &p2);
+       if (ret != 3)
+               return -EINVAL;
 
        if (cmd == SD_TOOL_ZONE) {
                id = p1;