OSDN Git Service

ALSA: fireworks: Fix wrong value as argument for PTR_ERR()
authorTakashi Sakamoto <o-takashi@sakamocchi.jp>
Tue, 27 May 2014 15:14:38 +0000 (00:14 +0900)
committerTakashi Iwai <tiwai@suse.de>
Tue, 27 May 2014 15:34:52 +0000 (17:34 +0200)
The return value of memdup_user() should be passed to return correct error.

Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/firewire/fireworks/fireworks_hwdep.c

index 6b50a67..4f8216f 100644 (file)
@@ -135,7 +135,7 @@ hwdep_write(struct snd_hwdep *hwdep, const char __user *data, long count,
 
        buf = memdup_user(data, count);
        if (IS_ERR(buf))
-               return PTR_ERR(data);
+               return PTR_ERR(buf);
 
        /* check seqnum is not for kernel-land */
        seqnum = be32_to_cpu(((struct snd_efw_transaction *)buf)->seqnum);