OSDN Git Service

mmc: debugfs: Fix file release memory leak
authorWei Yongjun <weiyongjun1@huawei.com>
Wed, 8 Jun 2022 09:01:52 +0000 (09:01 +0000)
committerUlf Hansson <ulf.hansson@linaro.org>
Tue, 12 Jul 2022 10:25:36 +0000 (12:25 +0200)
When using single_open() for opening, single_release() should be
used instead of seq_release(), otherwise there is a memory leak.

Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Acked-by: Adrian Hunter <adrian.hunter@intel.com>
Link: https://lore.kernel.org/r/20220608090152.179395-1-weiyongjun1@huawei.com
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
drivers/mmc/core/debugfs.c

index 75e98ec..fe68087 100644 (file)
@@ -295,6 +295,7 @@ static const struct file_operations mmc_err_stats_fops = {
        .open   = mmc_err_stats_open,
        .read   = seq_read,
        .write  = mmc_err_stats_write,
+       .release = single_release,
 };
 
 void mmc_add_host_debugfs(struct mmc_host *host)