OSDN Git Service

Staging: gdm724x: LTE: Refactor gdm_lte_pdn_table().
authorQuytelda Kahja <quytelda@tamalin.org>
Fri, 23 Feb 2018 01:33:01 +0000 (17:33 -0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 23 Feb 2018 08:54:56 +0000 (09:54 +0100)
Mostly this change just reverses the primary conditional so most of
the code can be pulled back a tab, which fixes some code style
warnings.

Signed-off-by: Quytelda Kahja <quytelda@tamalin.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/gdm724x/gdm_lte.c

index 92cb9d1..4f3c518 100644 (file)
@@ -730,21 +730,21 @@ static void gdm_lte_pdn_table(struct net_device *dev, char *buf, int len)
 {
        struct nic *nic = netdev_priv(dev);
        struct hci_pdn_table_ind *pdn_table = (struct hci_pdn_table_ind *)buf;
-       u8 ed;
+       u8 ed = nic->phy_dev->get_endian(nic->phy_dev->priv_dev);
 
-       if (pdn_table->activate) {
-               nic->pdn_table.activate = pdn_table->activate;
-
-               ed = nic->phy_dev->get_endian(nic->phy_dev->priv_dev);
-               nic->pdn_table.dft_eps_id = gdm_dev32_to_cpu(ed, pdn_table->dft_eps_id);
-               nic->pdn_table.nic_type = gdm_dev32_to_cpu(ed, pdn_table->nic_type);
-
-               netdev_info(dev, "pdn activated, nic_type=0x%x\n",
-                           nic->pdn_table.nic_type);
-       } else {
+       if (!pdn_table->activate) {
                memset(&nic->pdn_table, 0x00, sizeof(struct pdn_table));
                netdev_info(dev, "pdn deactivated\n");
+
+               return;
        }
+
+       nic->pdn_table.activate = pdn_table->activate;
+       nic->pdn_table.dft_eps_id = gdm_dev32_to_cpu(ed, pdn_table->dft_eps_id);
+       nic->pdn_table.nic_type = gdm_dev32_to_cpu(ed, pdn_table->nic_type);
+
+       netdev_info(dev, "pdn activated, nic_type=0x%x\n",
+                   nic->pdn_table.nic_type);
 }
 
 static int gdm_lte_receive_pkt(struct phy_dev *phy_dev, char *buf, int len)