OSDN Git Service

afs: Fix key ref leak in afs_put_operation()
authorDavid Howells <dhowells@redhat.com>
Thu, 20 Aug 2020 13:37:12 +0000 (14:37 +0100)
committerLinus Torvalds <torvalds@linux-foundation.org>
Thu, 20 Aug 2020 17:41:45 +0000 (10:41 -0700)
The afs_put_operation() function needs to put the reference to the key
that's authenticating the operation.

Fixes: e49c7b2f6de7 ("afs: Build an abstraction around an "operation" concept")
Reported-by: Dave Botsch <botsch@cnf.cornell.edu>
Signed-off-by: David Howells <dhowells@redhat.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
fs/afs/fs_operation.c

index 24fd163..97cab12 100644 (file)
@@ -235,6 +235,7 @@ int afs_put_operation(struct afs_operation *op)
        afs_end_cursor(&op->ac);
        afs_put_serverlist(op->net, op->server_list);
        afs_put_volume(op->net, op->volume, afs_volume_trace_put_put_op);
+       key_put(op->key);
        kfree(op);
        return ret;
 }