f2fs: cleanup the code in build_sit_entries.

We do not need to set the SBI_NEED_FSCK flag in the error paths, if we
return error here, we will not update the checkpoint flag, so the code
is useless, just remove it.

Signed-off-by: Lihong Kou <koulihong@huawei.com>
Reviewed-by: Chao Yu <yuchao0@huawei.com>
Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>

diff --git a/fs/f2fs/segment.c b/fs/f2fs/segment.c
index fafac7b..1e8c0e9 100644 (file)
--- a/fs/f2fs/segment.c
+++ b/fs/f2fs/segment.c
@@ -4246,7 +4246,6 @@ static int build_sit_entries(struct f2fs_sb_info *sbi)
                if (start >= MAIN_SEGS(sbi)) {
                        f2fs_err(sbi, "Wrong journal entry on segno %u",
                                 start);
-                       set_sbi_flag(sbi, SBI_NEED_FSCK);
                        err = -EFSCORRUPTED;
                        break;
                }
@@ -4286,7 +4285,6 @@ static int build_sit_entries(struct f2fs_sb_info *sbi)
        if (!err && total_node_blocks != valid_node_count(sbi)) {
                f2fs_err(sbi, "SIT is corrupted node# %u vs %u",
                         total_node_blocks, valid_node_count(sbi));
-               set_sbi_flag(sbi, SBI_NEED_FSCK);
                err = -EFSCORRUPTED;
        }