OSDN Git Service

watchdog: rzg2l_wdt: Add error check for reset_control_deassert
authorBiju Das <biju.das.jz@bp.renesas.com>
Fri, 25 Feb 2022 17:53:18 +0000 (17:53 +0000)
committerWim Van Sebroeck <wim@linux-watchdog.org>
Sun, 8 May 2022 08:34:03 +0000 (10:34 +0200)
If reset_control_deassert() fails, then we won't be able to
access the device registers. Therefore check the return code of
reset_control_deassert() and bailout in case of error.

Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
Link: https://lore.kernel.org/r/20220225175320.11041-6-biju.das.jz@bp.renesas.com
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Wim Van Sebroeck <wim@linux-watchdog.org>
drivers/watchdog/rzg2l_wdt.c

index 8827470..73b667e 100644 (file)
@@ -203,7 +203,10 @@ static int rzg2l_wdt_probe(struct platform_device *pdev)
                return dev_err_probe(&pdev->dev, PTR_ERR(priv->rstc),
                                     "failed to get cpg reset");
 
-       reset_control_deassert(priv->rstc);
+       ret = reset_control_deassert(priv->rstc);
+       if (ret)
+               return dev_err_probe(dev, ret, "failed to deassert");
+
        pm_runtime_enable(&pdev->dev);
 
        priv->wdev.info = &rzg2l_wdt_ident;