OSDN Git Service

net: lan966x: fix a IS_ERR() vs NULL check in lan966x_create_targets()
authorDan Carpenter <dan.carpenter@oracle.com>
Fri, 3 Dec 2021 09:55:31 +0000 (12:55 +0300)
committerDavid S. Miller <davem@davemloft.net>
Fri, 3 Dec 2021 14:22:00 +0000 (14:22 +0000)
The devm_ioremap() function does not return error pointers.  It returns
NULL.

Fixes: db8bcaad5393 ("net: lan966x: add the basic lan966x driver")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Horatiu Vultur <horatiu.vultur@microchip.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/microchip/lan966x/lan966x_main.c

index be5e2b3..101c1f0 100644 (file)
@@ -83,10 +83,10 @@ static int lan966x_create_targets(struct platform_device *pdev,
                begin[idx] = devm_ioremap(&pdev->dev,
                                          iores[idx]->start,
                                          resource_size(iores[idx]));
-               if (IS_ERR(begin[idx])) {
+               if (!begin[idx]) {
                        dev_err(&pdev->dev, "Unable to get registers: %s\n",
                                iores[idx]->name);
-                       return PTR_ERR(begin[idx]);
+                       return -ENOMEM;
                }
        }