OSDN Git Service

radeon: no need to check return value of debugfs_create functions
authorGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 13 Jun 2019 11:56:31 +0000 (13:56 +0200)
committerAlex Deucher <alexander.deucher@amd.com>
Thu, 13 Jun 2019 18:59:49 +0000 (13:59 -0500)
When calling debugfs functions, there is no need to ever check the
return value.  The function can work or not, but the code logic should
never do something different based on this.

Cc: Alex Deucher <alexander.deucher@amd.com>
Cc: "Christian König" <christian.koenig@amd.com>
Cc: "David (ChunMing) Zhou" <David1.Zhou@amd.com>
Cc: David Airlie <airlied@linux.ie>
Cc: Daniel Vetter <daniel@ffwll.ch>
Cc: amd-gfx@lists.freedesktop.org
Cc: dri-devel@lists.freedesktop.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/radeon/radeon_ttm.c

index 5d42f8d..6bbccc7 100644 (file)
@@ -1056,19 +1056,14 @@ static int radeon_ttm_debugfs_init(struct radeon_device *rdev)
        unsigned count;
 
        struct drm_minor *minor = rdev->ddev->primary;
-       struct dentry *ent, *root = minor->debugfs_root;
-
-       ent = debugfs_create_file("radeon_vram", S_IFREG | S_IRUGO, root,
-                                 rdev, &radeon_ttm_vram_fops);
-       if (IS_ERR(ent))
-               return PTR_ERR(ent);
-       rdev->mman.vram = ent;
-
-       ent = debugfs_create_file("radeon_gtt", S_IFREG | S_IRUGO, root,
-                                 rdev, &radeon_ttm_gtt_fops);
-       if (IS_ERR(ent))
-               return PTR_ERR(ent);
-       rdev->mman.gtt = ent;
+       struct dentry *root = minor->debugfs_root;
+
+       rdev->mman.vram = debugfs_create_file("radeon_vram", S_IFREG | S_IRUGO,
+                                             root, rdev,
+                                             &radeon_ttm_vram_fops);
+
+       rdev->mman.gtt = debugfs_create_file("radeon_gtt", S_IFREG | S_IRUGO,
+                                            root, rdev, &radeon_ttm_gtt_fops);
 
        count = ARRAY_SIZE(radeon_ttm_debugfs_list);