OSDN Git Service

mfd: tps65010: Remove incorrect __exit markups
authorDmitry Torokhov <dmitry.torokhov@gmail.com>
Mon, 9 Mar 2015 17:47:15 +0000 (10:47 -0700)
committerLee Jones <lee.jones@linaro.org>
Thu, 9 Apr 2015 09:26:40 +0000 (10:26 +0100)
Even if bus is not hot-pluggable, the devices can be unbound from the
driver via sysfs, so we should not be using __exit annotations on
remove() methods. The only exception is drivers registered with
platform_driver_probe() which specifically disables sysfs bind/unbind
attributes.

Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Signed-off-by: Lee Jones <lee.jones@linaro.org>
drivers/mfd/tps65010.c

index 743fb52..448f0a1 100644 (file)
@@ -515,7 +515,7 @@ static int tps65010_gpio_get(struct gpio_chip *chip, unsigned offset)
 
 static struct tps65010 *the_tps;
 
-static int __exit tps65010_remove(struct i2c_client *client)
+static int tps65010_remove(struct i2c_client *client)
 {
        struct tps65010         *tps = i2c_get_clientdata(client);
        struct tps65010_board   *board = dev_get_platdata(&client->dev);
@@ -684,7 +684,7 @@ static struct i2c_driver tps65010_driver = {
                .name   = "tps65010",
        },
        .probe  = tps65010_probe,
-       .remove = __exit_p(tps65010_remove),
+       .remove = tps65010_remove,
        .id_table = tps65010_id,
 };