OSDN Git Service

QmlJS highlighting: Fix external object property highlight.
authorChristian Kamm <christian.d.kamm@nokia.com>
Wed, 14 Sep 2011 07:59:05 +0000 (09:59 +0200)
committerChristian Kamm <christian.d.kamm@nokia.com>
Wed, 14 Sep 2011 09:00:53 +0000 (11:00 +0200)
Change-Id: Ie9fa9aceb72c40ca2f991f48f70f89e5ab342436
Reviewed-on: http://codereview.qt-project.org/4870
Reviewed-by: Thomas Hartmann <Thomas.Hartmann@nokia.com>
src/plugins/qmljseditor/qmljssemantichighlighter.cpp

index dab142f..f3928ee 100644 (file)
@@ -240,12 +240,13 @@ protected:
                 type = SemanticHighlighter::ExternalIdType;
             } else if (scope == chain->rootObjectScope()) {
                 type = SemanticHighlighter::RootObjectPropertyType;
+            } else  { // check for this?
+                type = SemanticHighlighter::ExternalObjectPropertyType;
             }
-        } else { // check for this?
-            type = SemanticHighlighter::ExternalObjectPropertyType;
         }
 
-        addUse(location, type);
+        if (type != SemanticHighlighter::UnknownType)
+            addUse(location, type);
     }
 
     bool visit(UiObjectDefinition *ast)