OSDN Git Service

Revert "[Mips] Fix use after free."
authorBenjamin Kramer <benny.kra@googlemail.com>
Mon, 9 May 2016 10:31:17 +0000 (10:31 +0000)
committerBenjamin Kramer <benny.kra@googlemail.com>
Mon, 9 May 2016 10:31:17 +0000 (10:31 +0000)
Fixes use after free but breaks tests.

This reverts commit r268901.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@268902 91177308-0d34-0410-b5e6-96231b3b80d8

lib/Target/Mips/AsmParser/MipsAsmParser.cpp

index aed0004..1b61535 100644 (file)
@@ -4693,7 +4693,8 @@ MipsAsmParser::parseRegisterPair(OperandVector &Operands) {
   SMLoc E = Parser.getTok().getLoc();
   MipsOperand &Op = static_cast<MipsOperand &>(*Operands.back());
 
-  Operands.back() = MipsOperand::CreateRegPair(Op, S, E, *this);
+  Operands.pop_back();
+  Operands.push_back(MipsOperand::CreateRegPair(Op, S, E, *this));
   return MatchOperand_Success;
 }