OSDN Git Service

nfc: pn533: Constify pn533_phy_ops
authorRikard Falkeborn <rikard.falkeborn@gmail.com>
Wed, 6 Oct 2021 22:47:38 +0000 (00:47 +0200)
committerDavid S. Miller <davem@davemloft.net>
Thu, 7 Oct 2021 12:35:10 +0000 (13:35 +0100)
Neither the driver or the core modifies the pn533_phy_ops struct, so
make them const to allow the compiler to put the static structs in
read-only memory.

Signed-off-by: Rikard Falkeborn <rikard.falkeborn@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/nfc/pn533/i2c.c
drivers/nfc/pn533/pn533.c
drivers/nfc/pn533/pn533.h
drivers/nfc/pn533/uart.c
drivers/nfc/pn533/usb.c

index f5610b6..673eb5e 100644 (file)
@@ -156,7 +156,7 @@ static irqreturn_t pn533_i2c_irq_thread_fn(int irq, void *data)
        return IRQ_HANDLED;
 }
 
-static struct pn533_phy_ops i2c_phy_ops = {
+static const struct pn533_phy_ops i2c_phy_ops = {
        .send_frame = pn533_i2c_send_frame,
        .send_ack = pn533_i2c_send_ack,
        .abort_cmd = pn533_i2c_abort_cmd,
index da18033..787bcbd 100644 (file)
@@ -2733,7 +2733,7 @@ EXPORT_SYMBOL_GPL(pn533_finalize_setup);
 struct pn533 *pn53x_common_init(u32 device_type,
                                enum pn533_protocol_type protocol_type,
                                void *phy,
-                               struct pn533_phy_ops *phy_ops,
+                               const struct pn533_phy_ops *phy_ops,
                                struct pn533_frame_ops *fops,
                                struct device *dev)
 {
index 5f94f38..09e35b8 100644 (file)
@@ -177,7 +177,7 @@ struct pn533 {
 
        struct device *dev;
        void *phy;
-       struct pn533_phy_ops *phy_ops;
+       const struct pn533_phy_ops *phy_ops;
 };
 
 typedef int (*pn533_send_async_complete_t) (struct pn533 *dev, void *arg,
@@ -232,7 +232,7 @@ struct pn533_phy_ops {
 struct pn533 *pn53x_common_init(u32 device_type,
                                enum pn533_protocol_type protocol_type,
                                void *phy,
-                               struct pn533_phy_ops *phy_ops,
+                               const struct pn533_phy_ops *phy_ops,
                                struct pn533_frame_ops *fops,
                                struct device *dev);
 
index 77bb073..2caf997 100644 (file)
@@ -123,7 +123,7 @@ static int pn532_dev_down(struct pn533 *dev)
        return 0;
 }
 
-static struct pn533_phy_ops uart_phy_ops = {
+static const struct pn533_phy_ops uart_phy_ops = {
        .send_frame = pn532_uart_send_frame,
        .send_ack = pn532_uart_send_ack,
        .abort_cmd = pn532_uart_abort_cmd,
index bd7f747..6f71ac7 100644 (file)
@@ -429,7 +429,7 @@ static void pn533_send_complete(struct urb *urb)
        }
 }
 
-static struct pn533_phy_ops usb_phy_ops = {
+static const struct pn533_phy_ops usb_phy_ops = {
        .send_frame = pn533_usb_send_frame,
        .send_ack = pn533_usb_send_ack,
        .abort_cmd = pn533_usb_abort_cmd,