OSDN Git Service

pwm: rcar: Drop useless call to pwm_get_state()
authorUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Thu, 24 Oct 2019 07:14:09 +0000 (09:14 +0200)
committerThierry Reding <thierry.reding@gmail.com>
Mon, 20 Jan 2020 11:21:49 +0000 (12:21 +0100)
pwm_get_state has no side effects and the resulting pwm_state is unused.
So drop the call to pwm_get_state() and the local variable from
rcar_pwm_apply().

The call was introduced in commit 7f68ce8287d3 ("pwm: rcar: Add support
"atomic" API") and already then was useless.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Reviewed-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
Signed-off-by: Thierry Reding <thierry.reding@gmail.com>
drivers/pwm/pwm-rcar.c

index 852eb23..6fac8eb 100644 (file)
@@ -161,11 +161,9 @@ static int rcar_pwm_apply(struct pwm_chip *chip, struct pwm_device *pwm,
                          const struct pwm_state *state)
 {
        struct rcar_pwm_chip *rp = to_rcar_pwm_chip(chip);
-       struct pwm_state cur_state;
        int div, ret;
 
        /* This HW/driver only supports normal polarity */
-       pwm_get_state(pwm, &cur_state);
        if (state->polarity != PWM_POLARITY_NORMAL)
                return -ENOTSUPP;