OSDN Git Service

drm/exynos: Don't reset bridge->next
authorBoris Brezillon <boris.brezillon@collabora.com>
Wed, 23 Oct 2019 15:44:53 +0000 (17:44 +0200)
committerBoris Brezillon <boris.brezillon@collabora.com>
Mon, 2 Dec 2019 08:34:06 +0000 (09:34 +0100)
bridge->next is only points to the new bridge if drm_bridge_attach()
succeeds. No need to reset it manually here.

Note that this change is part of the attempt to make the bridge chain
a double-linked list. In order to do that we must patch all drivers
manipulating the bridge->next field.

Signed-off-by: Boris Brezillon <boris.brezillon@collabora.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Acked-by: Inki Dae <inki.dae@samsung.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20191023154512.9762-3-boris.brezillon@collabora.com
drivers/gpu/drm/exynos/exynos_dp.c

index 1e6aa24..4785885 100644 (file)
@@ -110,7 +110,6 @@ static int exynos_dp_bridge_attach(struct analogix_dp_plat_data *plat_data,
                if (ret) {
                        DRM_DEV_ERROR(dp->dev,
                                      "Failed to attach bridge to drm\n");
-                       bridge->next = NULL;
                        return ret;
                }
        }