OSDN Git Service

media: ccs: Fix return value from probe
authorSakari Ailus <sakari.ailus@linux.intel.com>
Fri, 4 Dec 2020 11:46:56 +0000 (12:46 +0100)
committerMauro Carvalho Chehab <mchehab+huawei@kernel.org>
Mon, 7 Dec 2020 12:56:00 +0000 (13:56 +0100)
rval wasn't set, resulting in probe returning zero instead of an error.

Fixes: de10c1619c48 ("[media] smiapp: Get clock rate if it's not available through DT")
Reported-by: Zhang Changzhong <zhangchangzhong@huawei.com>
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
drivers/media/i2c/ccs/ccs-core.c

index 7a461c0..5f69e4c 100644 (file)
@@ -3030,7 +3030,7 @@ static int ccs_probe(struct i2c_client *client)
                                dev_err(&client->dev,
                                        "can't set clock freq, asked for %u but got %lu\n",
                                        sensor->hwcfg.ext_clk, rate);
-                               return rval;
+                               return -EINVAL;
                        }
                } else {
                        sensor->hwcfg.ext_clk = clk_get_rate(sensor->ext_clk);