OSDN Git Service

drm/i915: Use local variable for SSEU info in GETPARAM ioctl
authorStuart Summers <stuart.summers@intel.com>
Fri, 24 May 2019 15:40:18 +0000 (08:40 -0700)
committerManasi Navare <manasi.d.navare@intel.com>
Tue, 28 May 2019 18:16:52 +0000 (11:16 -0700)
In the GETPARAM ioctl handler, use a local variable to consolidate
usage of SSEU runtime info.

v2: add const to sseu_dev_info variable

Cc: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
Reviewed-by: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
Signed-off-by: Stuart Summers <stuart.summers@intel.com>
Signed-off-by: Manasi Navare <manasi.d.navare@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20190524154022.13575-2-stuart.summers@intel.com
drivers/gpu/drm/i915/i915_drv.c

index 5ca1594..a759174 100644 (file)
@@ -332,6 +332,7 @@ static int i915_getparam_ioctl(struct drm_device *dev, void *data,
 {
        struct drm_i915_private *dev_priv = to_i915(dev);
        struct pci_dev *pdev = dev_priv->drm.pdev;
+       const struct sseu_dev_info *sseu = &RUNTIME_INFO(dev_priv)->sseu;
        drm_i915_getparam_t *param = data;
        int value;
 
@@ -385,12 +386,12 @@ static int i915_getparam_ioctl(struct drm_device *dev, void *data,
                value = i915_cmd_parser_get_version(dev_priv);
                break;
        case I915_PARAM_SUBSLICE_TOTAL:
-               value = sseu_subslice_total(&RUNTIME_INFO(dev_priv)->sseu);
+               value = sseu_subslice_total(sseu);
                if (!value)
                        return -ENODEV;
                break;
        case I915_PARAM_EU_TOTAL:
-               value = RUNTIME_INFO(dev_priv)->sseu.eu_total;
+               value = sseu->eu_total;
                if (!value)
                        return -ENODEV;
                break;
@@ -407,7 +408,7 @@ static int i915_getparam_ioctl(struct drm_device *dev, void *data,
                value = HAS_POOLED_EU(dev_priv);
                break;
        case I915_PARAM_MIN_EU_IN_POOL:
-               value = RUNTIME_INFO(dev_priv)->sseu.min_eu_in_pool;
+               value = sseu->min_eu_in_pool;
                break;
        case I915_PARAM_HUC_STATUS:
                value = intel_huc_check_status(&dev_priv->huc);
@@ -458,12 +459,12 @@ static int i915_getparam_ioctl(struct drm_device *dev, void *data,
                value = intel_engines_has_context_isolation(dev_priv);
                break;
        case I915_PARAM_SLICE_MASK:
-               value = RUNTIME_INFO(dev_priv)->sseu.slice_mask;
+               value = sseu->slice_mask;
                if (!value)
                        return -ENODEV;
                break;
        case I915_PARAM_SUBSLICE_MASK:
-               value = RUNTIME_INFO(dev_priv)->sseu.subslice_mask[0];
+               value = sseu->subslice_mask[0];
                if (!value)
                        return -ENODEV;
                break;