RDMA/qedr: Initialize ib_device_ops struct

Initialize ib_device_ops with the supported operations using
ib_set_device_ops().

Signed-off-by: Kamal Heib <kamalheib1@gmail.com>
Signed-off-by: Jason Gunthorpe <jgg@mellanox.com>

diff --git a/drivers/infiniband/hw/qedr/main.c b/drivers/infiniband/hw/qedr/main.c
index 8d6ff9d..75940e2 100644 (file)
--- a/drivers/infiniband/hw/qedr/main.c
+++ b/drivers/infiniband/hw/qedr/main.c
@@ -160,12 +160,16 @@ static const struct attribute_group qedr_attr_group = {
        .attrs = qedr_attributes,
 };
 
+static const struct ib_device_ops qedr_iw_dev_ops = {
+       .get_port_immutable = qedr_iw_port_immutable,
+       .query_gid = qedr_iw_query_gid,
+};
+
 static int qedr_iw_register_device(struct qedr_dev *dev)
 {
        dev->ibdev.node_type = RDMA_NODE_RNIC;
-       dev->ibdev.query_gid = qedr_iw_query_gid;
 
-       dev->ibdev.get_port_immutable = qedr_iw_port_immutable;
+       ib_set_device_ops(&dev->ibdev, &qedr_iw_dev_ops);
 
        dev->ibdev.iwcm = kzalloc(sizeof(*dev->ibdev.iwcm), GFP_KERNEL);
        if (!dev->ibdev.iwcm)
@@ -186,13 +190,56 @@ static int qedr_iw_register_device(struct qedr_dev *dev)
        return 0;
 }
 
+static const struct ib_device_ops qedr_roce_dev_ops = {
+       .get_port_immutable = qedr_roce_port_immutable,
+};
+
 static void qedr_roce_register_device(struct qedr_dev *dev)
 {
        dev->ibdev.node_type = RDMA_NODE_IB_CA;
 
-       dev->ibdev.get_port_immutable = qedr_roce_port_immutable;
+       ib_set_device_ops(&dev->ibdev, &qedr_roce_dev_ops);
 }
 
+static const struct ib_device_ops qedr_dev_ops = {
+       .alloc_mr = qedr_alloc_mr,
+       .alloc_pd = qedr_alloc_pd,
+       .alloc_ucontext = qedr_alloc_ucontext,
+       .create_ah = qedr_create_ah,
+       .create_cq = qedr_create_cq,
+       .create_qp = qedr_create_qp,
+       .create_srq = qedr_create_srq,
+       .dealloc_pd = qedr_dealloc_pd,
+       .dealloc_ucontext = qedr_dealloc_ucontext,
+       .dereg_mr = qedr_dereg_mr,
+       .destroy_ah = qedr_destroy_ah,
+       .destroy_cq = qedr_destroy_cq,
+       .destroy_qp = qedr_destroy_qp,
+       .destroy_srq = qedr_destroy_srq,
+       .get_dev_fw_str = qedr_get_dev_fw_str,
+       .get_dma_mr = qedr_get_dma_mr,
+       .get_link_layer = qedr_link_layer,
+       .get_netdev = qedr_get_netdev,
+       .map_mr_sg = qedr_map_mr_sg,
+       .mmap = qedr_mmap,
+       .modify_port = qedr_modify_port,
+       .modify_qp = qedr_modify_qp,
+       .modify_srq = qedr_modify_srq,
+       .poll_cq = qedr_poll_cq,
+       .post_recv = qedr_post_recv,
+       .post_send = qedr_post_send,
+       .post_srq_recv = qedr_post_srq_recv,
+       .process_mad = qedr_process_mad,
+       .query_device = qedr_query_device,
+       .query_pkey = qedr_query_pkey,
+       .query_port = qedr_query_port,
+       .query_qp = qedr_query_qp,
+       .query_srq = qedr_query_srq,
+       .reg_user_mr = qedr_reg_user_mr,
+       .req_notify_cq = qedr_arm_cq,
+       .resize_cq = qedr_resize_cq,
+};
+
 static int qedr_register_device(struct qedr_dev *dev)
 {
        int rc;
@@ -237,57 +284,11 @@ static int qedr_register_device(struct qedr_dev *dev)
 
        dev->ibdev.phys_port_cnt = 1;
        dev->ibdev.num_comp_vectors = dev->num_cnq;
-
-       dev->ibdev.query_device = qedr_query_device;
-       dev->ibdev.query_port = qedr_query_port;
-       dev->ibdev.modify_port = qedr_modify_port;
-
-       dev->ibdev.alloc_ucontext = qedr_alloc_ucontext;
-       dev->ibdev.dealloc_ucontext = qedr_dealloc_ucontext;
-       dev->ibdev.mmap = qedr_mmap;
-
-       dev->ibdev.alloc_pd = qedr_alloc_pd;
-       dev->ibdev.dealloc_pd = qedr_dealloc_pd;
-
-       dev->ibdev.create_cq = qedr_create_cq;
-       dev->ibdev.destroy_cq = qedr_destroy_cq;
-       dev->ibdev.resize_cq = qedr_resize_cq;
-       dev->ibdev.req_notify_cq = qedr_arm_cq;
-
-       dev->ibdev.create_qp = qedr_create_qp;
-       dev->ibdev.modify_qp = qedr_modify_qp;
-       dev->ibdev.query_qp = qedr_query_qp;
-       dev->ibdev.destroy_qp = qedr_destroy_qp;
-
-       dev->ibdev.create_srq = qedr_create_srq;
-       dev->ibdev.destroy_srq = qedr_destroy_srq;
-       dev->ibdev.modify_srq = qedr_modify_srq;
-       dev->ibdev.query_srq = qedr_query_srq;
-       dev->ibdev.post_srq_recv = qedr_post_srq_recv;
-       dev->ibdev.query_pkey = qedr_query_pkey;
-
-       dev->ibdev.create_ah = qedr_create_ah;
-       dev->ibdev.destroy_ah = qedr_destroy_ah;
-
-       dev->ibdev.get_dma_mr = qedr_get_dma_mr;
-       dev->ibdev.dereg_mr = qedr_dereg_mr;
-       dev->ibdev.reg_user_mr = qedr_reg_user_mr;
-       dev->ibdev.alloc_mr = qedr_alloc_mr;
-       dev->ibdev.map_mr_sg = qedr_map_mr_sg;
-
-       dev->ibdev.poll_cq = qedr_poll_cq;
-       dev->ibdev.post_send = qedr_post_send;
-       dev->ibdev.post_recv = qedr_post_recv;
-
-       dev->ibdev.process_mad = qedr_process_mad;
-
-       dev->ibdev.get_netdev = qedr_get_netdev;
-
        dev->ibdev.dev.parent = &dev->pdev->dev;
 
-       dev->ibdev.get_link_layer = qedr_link_layer;
-       dev->ibdev.get_dev_fw_str = qedr_get_dev_fw_str;
        rdma_set_device_sysfs_group(&dev->ibdev, &qedr_attr_group);
+       ib_set_device_ops(&dev->ibdev, &qedr_dev_ops);
+
        dev->ibdev.driver_id = RDMA_DRIVER_QEDR;
        return ib_register_device(&dev->ibdev, "qedr%d", NULL);
 }