OSDN Git Service

net: mvpp2: Improve a size determination in two functions
authorMarkus Elfring <elfring@users.sourceforge.net>
Mon, 17 Apr 2017 08:40:32 +0000 (10:40 +0200)
committerDavid S. Miller <davem@davemloft.net>
Tue, 18 Apr 2017 17:55:08 +0000 (13:55 -0400)
Replace the specification of two data structures by pointer dereferences
as the parameter for the operator "sizeof" to make the corresponding size
determination a bit safer according to the Linux coding style convention.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/marvell/mvpp2.c

index 61fd87d..3bddb8f 100644 (file)
@@ -2024,7 +2024,7 @@ static int mvpp2_prs_vlan_add(struct mvpp2 *priv, unsigned short tpid, int ai,
                        goto error;
                }
 
-               memset(pe, 0 , sizeof(struct mvpp2_prs_entry));
+               memset(pe, 0, sizeof(*pe));
                mvpp2_prs_tcam_lu_set(pe, MVPP2_PRS_LU_VLAN);
                pe->index = tid;
 
@@ -2165,7 +2165,7 @@ static int mvpp2_prs_double_vlan_add(struct mvpp2 *priv, unsigned short tpid1,
                        goto error;
                }
 
-               memset(pe, 0, sizeof(struct mvpp2_prs_entry));
+               memset(pe, 0, sizeof(*pe));
                mvpp2_prs_tcam_lu_set(pe, MVPP2_PRS_LU_VLAN);
                pe->index = tid;