OSDN Git Service

scsi: target: Fix iscsi transport id buf len calculation
authorMike Christie <michael.christie@oracle.com>
Thu, 2 Jul 2020 01:43:22 +0000 (20:43 -0500)
committerMartin K. Petersen <martin.petersen@oracle.com>
Wed, 8 Jul 2020 04:14:34 +0000 (00:14 -0400)
The isid returned to the initiator is in string format which is 12
bytes. We also only add 1 terminating NULL and not one after the initiator
name and another one after the isid.

Link: https://lore.kernel.org/r/1593654203-12442-7-git-send-email-michael.christie@oracle.com
Signed-off-by: Mike Christie <michael.christie@oracle.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/target/target_core_fabric_lib.c

index 428e5a1..1d2762a 100644 (file)
@@ -234,7 +234,7 @@ static int iscsi_get_pr_transport_id_len(
         */
        if (pr_reg->isid_present_at_reg) {
                len += 5; /* For ",i,0x" ASCII separator */
-               len += 7; /* For iSCSI Initiator Session ID + Null terminator */
+               len += 12; /* For iSCSI Initiator Session ID */
                *format_code = 1;
        } else
                *format_code = 0;