OSDN Git Service

ARM: dts: sun8i: a83t: Fix incorrect clk and reset macros for EMAC device
authorChen-Yu Tsai <wens@csie.org>
Tue, 14 Jan 2020 09:42:52 +0000 (17:42 +0800)
committerMaxime Ripard <maxime@cerno.tech>
Mon, 10 Feb 2020 07:58:02 +0000 (08:58 +0100)
When the raw numbers used for clk and reset indices in the EMAC device
node were converted to the new macros, the order of the clk and reset
properties was overlooked, and thus the incorrect macros were used.
This results in the EMAC being non-responsive, as well as an oops due
to incorrect usage of the reset control.

Correct the macro types, and also reorder the clk and reset properties
to match all the other device nodes.

Fixes: 765866edb16a ("ARM: dts: sunxi: Use macros for references to CCU clocks")
Signed-off-by: Chen-Yu Tsai <wens@csie.org>
Tested-by: Corentin Labbe <clabbe.montjoie@gmail.com>
Signed-off-by: Maxime Ripard <maxime@cerno.tech>
arch/arm/boot/dts/sun8i-a83t.dtsi

index 74ac7ee..e7b9bef 100644 (file)
                        reg = <0x01c30000 0x104>;
                        interrupts = <GIC_SPI 82 IRQ_TYPE_LEVEL_HIGH>;
                        interrupt-names = "macirq";
-                       resets = <&ccu CLK_BUS_EMAC>;
-                       reset-names = "stmmaceth";
-                       clocks = <&ccu RST_BUS_EMAC>;
+                       clocks = <&ccu CLK_BUS_EMAC>;
                        clock-names = "stmmaceth";
+                       resets = <&ccu RST_BUS_EMAC>;
+                       reset-names = "stmmaceth";
                        status = "disabled";
 
                        mdio: mdio {