OSDN Git Service

drm/i915/tv: Nuke silly 0 initialzation of xpos/ypos
authorVille Syrjälä <ville.syrjala@linux.intel.com>
Mon, 12 Nov 2018 16:59:51 +0000 (18:59 +0200)
committerVille Syrjälä <ville.syrjala@linux.intel.com>
Fri, 25 Jan 2019 16:50:53 +0000 (18:50 +0200)
Just assign the margin values directly to xpos/ypos instead
of first initializing to zero and then adding the values.

Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20181112170000.27531-8-ville.syrjala@linux.intel.com
Reviewed-by: Imre Deak <imre.deak@intel.com>
drivers/gpu/drm/i915/intel_tv.c

index 0536077..0910ead 100644 (file)
@@ -993,7 +993,7 @@ static void intel_tv_pre_enable(struct intel_encoder *encoder,
        const struct video_levels *video_levels;
        const struct color_conversion *color_conversion;
        bool burst_ena;
-       int xpos = 0x0, ypos = 0x0;
+       int xpos, ypos;
        unsigned int xsize, ysize;
 
        if (!tv_mode)
@@ -1102,8 +1102,8 @@ static void intel_tv_pre_enable(struct intel_encoder *encoder,
        else
                ysize = 2 * (tv_mode->nbr_end + 1);
 
-       xpos += conn_state->tv.margins.left;
-       ypos += conn_state->tv.margins.top;
+       xpos = conn_state->tv.margins.left;
+       ypos = conn_state->tv.margins.top;
        xsize -= (conn_state->tv.margins.left +
                  conn_state->tv.margins.right);
        ysize -= (conn_state->tv.margins.top +