OSDN Git Service

platform/x86: dell-smo8800: Use min_t() for comparison and assignment
authorDeepak R Varma <drv@mailo.com>
Fri, 27 Jan 2023 16:31:49 +0000 (22:01 +0530)
committerHans de Goede <hdegoede@redhat.com>
Fri, 3 Feb 2023 09:01:50 +0000 (10:01 +0100)
Simplify code by using min_t helper macro for logical evaluation
and value assignment. Use the _t variant of min macro since the
variable types are not same.
This issue is identified by coccicheck using the minmax.cocci file.

Signed-off-by: Deepak R Varma <drv@mailo.com>
Acked-by: Pali Rohár <pali@kernel.org>
Link: https://lore.kernel.org/r/Y9P8debIztOZXazW@ubun2204.myguest.virtualbox.org
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
drivers/platform/x86/dell/dell-smo8800.c

index 3385e85..8d6b7a8 100644 (file)
@@ -67,10 +67,7 @@ static ssize_t smo8800_misc_read(struct file *file, char __user *buf,
 
        retval = 1;
 
-       if (data < 255)
-               byte_data = data;
-       else
-               byte_data = 255;
+       byte_data = min_t(u32, data, 255);
 
        if (put_user(byte_data, buf))
                retval = -EFAULT;