OSDN Git Service

drm/i915: checking for NULL instead of IS_ERR() in mock selftests
authorDan Carpenter <dan.carpenter@oracle.com>
Thu, 13 Apr 2017 19:52:17 +0000 (22:52 +0300)
committerChris Wilson <chris@chris-wilson.co.uk>
Thu, 13 Apr 2017 20:26:56 +0000 (21:26 +0100)
i915_gem_request_alloc() uses error pointers.  It never returns NULLs.

Fixes: 0daf0113cff6 ("drm/i915: Mock infrastructure for request emission")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Link: http://patchwork.freedesktop.org/patch/msgid/20170413195217.GA26108@mwanda
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
drivers/gpu/drm/i915/selftests/mock_request.c

index 0e8d2e7..8097e36 100644 (file)
@@ -35,7 +35,7 @@ mock_request(struct intel_engine_cs *engine,
 
        /* NB the i915->requests slab cache is enlarged to fit mock_request */
        request = i915_gem_request_alloc(engine, context);
-       if (!request)
+       if (IS_ERR(request))
                return NULL;
 
        mock = container_of(request, typeof(*mock), base);