OSDN Git Service

ASoC: soc-component: Add missed return for calling soc_component_ret
authorShengjiu Wang <shengjiu.wang@nxp.com>
Thu, 16 Jul 2020 05:07:08 +0000 (13:07 +0800)
committerMark Brown <broonie@kernel.org>
Thu, 16 Jul 2020 22:51:47 +0000 (23:51 +0100)
Add missed return for calling soc_component_ret, otherwise the return
value is wrong.

Fixes: e2329eeba45f ("ASoC: soc-component: add soc_component_err()")
Signed-off-by: Shengjiu Wang <shengjiu.wang@nxp.com>
Acked-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Link: https://lore.kernel.org/r/1594876028-1845-1-git-send-email-shengjiu.wang@nxp.com
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/soc-component.c

index af9909c..9565a0d 100644 (file)
@@ -647,7 +647,7 @@ int snd_soc_pcm_component_sync_stop(struct snd_pcm_substream *substream)
                        ret = component->driver->sync_stop(component,
                                                           substream);
                        if (ret < 0)
-                               soc_component_ret(component, ret);
+                               return soc_component_ret(component, ret);
                }
        }
 
@@ -705,7 +705,7 @@ int snd_soc_pcm_component_mmap(struct snd_pcm_substream *substream,
        /* FIXME. it returns 1st mmap now */
        for_each_rtd_components(rtd, i, component)
                if (component->driver->mmap)
-                       soc_component_ret(
+                       return soc_component_ret(
                                component,
                                component->driver->mmap(component,
                                                        substream, vma));
@@ -723,7 +723,7 @@ int snd_soc_pcm_component_new(struct snd_soc_pcm_runtime *rtd)
                if (component->driver->pcm_construct) {
                        ret = component->driver->pcm_construct(component, rtd);
                        if (ret < 0)
-                               soc_component_ret(component, ret);
+                               return soc_component_ret(component, ret);
                }
        }