OSDN Git Service

video: fbdev: valkyriefb.c: fix warning comparing pointer to 0
authorJason Yan <yanaijie@huawei.com>
Wed, 29 Apr 2020 14:09:42 +0000 (22:09 +0800)
committerSam Ravnborg <sam@ravnborg.org>
Wed, 6 May 2020 19:04:45 +0000 (21:04 +0200)
Fix the following coccicheck warning:

drivers/video/fbdev/valkyriefb.c:348:10-11: WARNING comparing pointer to
0, suggest !E
drivers/video/fbdev/valkyriefb.c:334:12-13: WARNING comparing pointer to
0
drivers/video/fbdev/valkyriefb.c:348:10-11: WARNING comparing pointer to
0

Signed-off-by: Jason Yan <yanaijie@huawei.com>
Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20200429140942.8137-1-yanaijie@huawei.com
drivers/video/fbdev/valkyriefb.c

index 4d20c46..8425afe 100644 (file)
@@ -331,7 +331,7 @@ int __init valkyriefb_init(void)
                struct resource r;
 
                dp = of_find_node_by_name(NULL, "valkyrie");
-               if (dp == 0)
+               if (!dp)
                        return 0;
 
                if (of_address_to_resource(dp, 0, &r)) {
@@ -345,7 +345,7 @@ int __init valkyriefb_init(void)
 #endif /* ppc (!CONFIG_MAC) */
 
        p = kzalloc(sizeof(*p), GFP_ATOMIC);
-       if (p == 0)
+       if (!p)
                return -ENOMEM;
 
        /* Map in frame buffer and registers */