OSDN Git Service

platform: goldfish: pipe: Replace "x==NULL" to "!x"
authorRoman Kiryanov <rkir@google.com>
Mon, 27 Aug 2018 18:23:15 +0000 (11:23 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 14 Sep 2018 13:31:31 +0000 (15:31 +0200)
checkpatch: Comparison to NULL could be written "!x"

Signed-off-by: Roman Kiryanov <rkir@google.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/platform/goldfish/goldfish_pipe.c

index c892a04..b4a484b 100644 (file)
@@ -699,7 +699,7 @@ static int goldfish_pipe_open(struct inode *inode, struct file *file)
 
        /* Allocate new pipe kernel object */
        struct goldfish_pipe *pipe = kzalloc(sizeof(*pipe), GFP_KERNEL);
-       if (pipe == NULL)
+       if (!pipe)
                return -ENOMEM;
 
        pipe->dev = dev;
@@ -865,23 +865,23 @@ static int goldfish_pipe_probe(struct platform_device *pdev)
        struct goldfish_pipe_dev *dev = &goldfish_pipe_dev;
 
        /* not thread safe, but this should not happen */
-       WARN_ON(dev->base != NULL);
+       WARN_ON(dev->base);
 
        spin_lock_init(&dev->lock);
 
        r = platform_get_resource(pdev, IORESOURCE_MEM, 0);
-       if (r == NULL || resource_size(r) < PAGE_SIZE) {
+       if (!r || resource_size(r) < PAGE_SIZE) {
                dev_err(&pdev->dev, "can't allocate i/o page\n");
                return -EINVAL;
        }
        dev->base = devm_ioremap(&pdev->dev, r->start, PAGE_SIZE);
-       if (dev->base == NULL) {
+       if (!dev->base) {
                dev_err(&pdev->dev, "ioremap failed\n");
                return -EINVAL;
        }
 
        r = platform_get_resource(pdev, IORESOURCE_IRQ, 0);
-       if (r == NULL) {
+       if (!r) {
                err = -EINVAL;
                goto error;
        }