OSDN Git Service

skge: remove redundunt free_irq under spinlock
authorStephen Hemminger <stephen@networkplumber.org>
Tue, 12 Dec 2017 18:30:29 +0000 (10:30 -0800)
committerDavid S. Miller <davem@davemloft.net>
Wed, 13 Dec 2017 20:47:00 +0000 (15:47 -0500)
The code to handle multi-port SKGE boards was freeing IRQ
twice. The first one was under lock and might sleep.

Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/marvell/skge.c

index 6e423f0..31efc47 100644 (file)
@@ -4081,7 +4081,6 @@ static void skge_remove(struct pci_dev *pdev)
        if (hw->ports > 1) {
                skge_write32(hw, B0_IMSK, 0);
                skge_read32(hw, B0_IMSK);
-               free_irq(pdev->irq, hw);
        }
        spin_unlock_irq(&hw->hw_lock);