OSDN Git Service

remove redundant quality limit check in QPNGImageWriter::writeImage()
authorIvailo Monev <xakepa10@gmail.com>
Tue, 18 Aug 2020 19:20:44 +0000 (22:20 +0300)
committerIvailo Monev <xakepa10@gmail.com>
Tue, 18 Aug 2020 19:41:14 +0000 (22:41 +0300)
already mapped from 0-100 to 0-9 in QPngHandler::write()

Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
src/gui/image/qpnghandler.cpp

index 584eb46..c7ad71d 100644 (file)
@@ -533,18 +533,11 @@ bool QPNGImageWriter::writeImage(const QImage& image, int quality_in)
         return false;
     }
 
-    if (quality_in >= 0) {
-        if (Q_UNLIKELY(quality_in > 9)) {
-            qWarning("PNG: Quality %d out of range", quality_in);
-            png_set_compression_level(png_ptr, 9);
-        } else {
-            png_set_compression_level(png_ptr, quality_in);
-        }
-    }
+    Q_ASSERT(quality_in >= 0 && quality_in <= 9);
+    png_set_compression_level(png_ptr, quality_in);
 
     png_set_write_fn(png_ptr, (void*)this, qpiw_write_fn, qpiw_flush_fn);
 
-
     int color_type = 0;
     if (image.colorCount())
         color_type = PNG_COLOR_TYPE_PALETTE;